[Devel] [PATCH 2/3] user.c: use kmem_cache_zalloc()

Alexey Dobriyan adobriyan at sw.ru
Fri Sep 21 02:39:06 PDT 2007


Quite a few fields are zeroed during user_struct creation, so use
kmem_cache_zalloc() --  save a few lines and #ifdef. Also will help avoid
 #ifdef CONFIG_POSIX_MQUEUE in next patch.

Signed-off-by: Alexey Dobriyan <adobriyan at sw.ru>
---

 kernel/user.c |   13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

--- a/kernel/user.c
+++ b/kernel/user.c
@@ -129,21 +129,11 @@ struct user_struct * alloc_uid(struct user_namespace *ns, uid_t uid)
 	if (!up) {
 		struct user_struct *new;
 
-		new = kmem_cache_alloc(uid_cachep, GFP_KERNEL);
+		new = kmem_cache_zalloc(uid_cachep, GFP_KERNEL);
 		if (!new)
 			return NULL;
 		new->uid = uid;
 		atomic_set(&new->__count, 1);
-		atomic_set(&new->processes, 0);
-		atomic_set(&new->files, 0);
-		atomic_set(&new->sigpending, 0);
-#ifdef CONFIG_INOTIFY_USER
-		atomic_set(&new->inotify_watches, 0);
-		atomic_set(&new->inotify_devs, 0);
-#endif
-
-		new->mq_bytes = 0;
-		new->locked_shm = 0;
 
 		if (alloc_uid_keyring(new, current) < 0) {
 			kmem_cache_free(uid_cachep, new);




More information about the Devel mailing list