[Devel] Re: [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net

David Miller davem at davemloft.net
Sun Sep 16 17:07:00 PDT 2007


From: ebiederm at xmission.com (Eric W. Biederman)
Date: Sun, 16 Sep 2007 18:06:00 -0600

> I did that audit when I replied to Stephen the first time and I just
> redid it to verify myself.  We are calling functions that can fail
> from the init function (kmalloc in the most common).  So the
> init function can fail.
> 
> So short of adding a bunch of BUG_ON's to the kernel to trap those
> failure cases we can't remove the backwards list walk.  Especially
> since I can initiate this code path as root by calling 
> "clone(CLONE_NEWNET...)".

I just noticed that posting and thanks for reiterating.




More information about the Devel mailing list