[Devel] Re: [PATCH 23/29] memory controller memory accounting v7

Balbir Singh balbir at linux.vnet.ibm.com
Thu Sep 13 03:29:08 PDT 2007


Peter Zijlstra wrote:
> On Thu, 2007-09-13 at 15:19 +0530, Balbir Singh wrote:
> 
>> VM_BUG_ON(pc && !locked)
> 
> Even better :-)
> 

Good, I'll change it.

>> I am not sure I understand this comment.
> 
> Is that inc needed? the pc is already associated with the page and
> should thus already have a reference, so this inc would do 1->2, but we
> then set it to 1 again. seems like a superfluous operation.

That is something I need to look into. I'll try and get to it soon.


-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list