[Devel] Re: [patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove

[Eric W. Biederman]

Daniel Lezcano <dlezcano at fr.ibm.com> writes:

> The file /proc/net/if_inet6 is removed twice.
> First time in:
>         inet6_exit
>              ->addrconf_cleanup
> And followed a few lines after by:
>         inet6_exit
>              -> if6_proc_exit
>
> Signed-off-by: Daniel Lezcano <dlezcano at fr.ibm.com>
Acked-by: "Eric W. Biederman" <ebiederm at xmission.com>

Looks like a good clean up to me.




> ---
>  net/ipv6/addrconf.c |    4 ----
>  1 file changed, 4 deletions(-)
>
> Index: net-2.6/net/ipv6/addrconf.c
> ===================================================================
> --- net-2.6.orig/net/ipv6/addrconf.c
> +++ net-2.6/net/ipv6/addrconf.c
> @@ -4288,8 +4288,4 @@ void __exit addrconf_cleanup(void)
>  	del_timer(&addr_chk_timer);
>  
>  	rtnl_unlock();
> -
> -#ifdef CONFIG_PROC_FS
> -	proc_net_remove(&init_net, "if_inet6");
> -#endif
>  }
>
> -- 
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers