[Devel] Re: [PATCH][NETNS] release net when pneigh_lookup fails

[Daniel Lezcano]

Dave Hansen wrote:
> On Tue, 2007-10-30 at 14:06 +0100, Daniel Lezcano wrote:
>> Index: linux-2.6-netns/net/core/neighbour.c
>> ===================================================================
>> --- linux-2.6-netns.orig/net/core/neighbour.c
>> +++ linux-2.6-netns/net/core/neighbour.c
>> @@ -497,6 +497,7 @@ struct pneigh_entry * pneigh_lookup(stru
>>          if (tbl->pconstructor && tbl->pconstructor(n)) {
>>                  if (dev)
>>                          dev_put(dev);
>> +               release_net(n->net);
>>                  kfree(n);
>>                  n = NULL;
>>                  goto out;
>> _______________________________________________ 
> 
> Looks like there are some tabs vs. spaces issues in there.  You should
> probably just make your line match the ones around it.

Thanks Dave for pointing that. I stupidly did a copy/paste from emacs to 
thunderbird. Grr ...
I will resend this patch with correct indentation. Benjamin spotted this 
problem with the patches I sent to netdev@ too, they are already fixed.

Thansk again.



_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers