[Devel] Re: [RFC][ for -mm] memory cgroup enhancements take3 [9/9] per zone stat

[KAMEZAWA Hiroyuki]

On Tue, 30 Oct 2007 21:32:59 +0900 (JST)
yamamoto at valinux.co.jp (YAMAMOTO Takashi) wrote:

> > +
> > +/*
> > + * Per-zone statistics.
> > + * Please be carefull. The array can be very big on envrionments whic has
> > + * very big MAX_NUMNODES . Adding new stat member to this will eat much memory.
> > + * Only Active/Inactive may be sutiable.
> 
> s/whic/&h/
> s/sutiable/suitable/
> 
> > +static inline void __mem_cgroup_zonesta_dec(struct mem_cgroup_zonestat *zstat,
> 
> s/zonesta/&t/
> 
thanks...maybe patch refresh was wrong.

> > +	if (active && !(pc->flags & PAGE_CGROUP_FLAG_ACTIVE))
> > +		direction = 1; /*from inactive to acvive */
> > +	if (!active && (pc->flags & PAGE_CGROUP_FLAG_ACTIVE))
> > +		direction = -1;
> > +
> > +	if (direction) {
> > +		struct mem_cgroup_zonestat *zstat = &pc->mem_cgroup->zonestat;
> > +		int index = page_cgroup_to_zonestat_index(pc);
> > +		preempt_disable();
> > +		__mem_cgroup_zonestat_add(zstat, MEM_CGROUP_ZONESTAT_ACTIVE,
> > +			direction, index);
> > +		__mem_cgroup_zonestat_add(zstat, MEM_CGROUP_ZONESTAT_INACTIVE,
> > +			direction, index);
> 
> dec?
> 
direction(add value) is 1 or -1 here. Hmm, this is maybe confusing.
ok, I'll clean up this.

Thanks,
-Kame
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers