[Devel] Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n
Benjamin Thery
benjamin.thery at bull.net
Fri Oct 26 04:41:55 PDT 2007
David Miller wrote:
> From: ebiederm at xmission.com (Eric W. Biederman)
> Date: Thu, 25 Oct 2007 11:21:55 -0600
>
>>> By the way, I think that we can in the case of undefined CONFIG_NET_NS
>>> reduce register to calling ->init method and unregister to calling
>>> ->exit method.
>>>
>>> This is a correct thing at least for now and will be welcomed by the all
>>> embedded/etc people.
>> I'm not fundamentally opposed. Earlier versions of my patchset
>> did that and more. However I think the pain is greater then the
>> gain right now. Especially since this concept seem to require
>> having quality inspected into it.
>
> I think the correct thing to do for now is to simply remove these
> __net_* markers and their definitions. There are so many tricky cases
> that it is easier to just get rid of them.
>
> Could someone send me a patch which does that?
The attached patch revert Pavel's orginal patch from 2.6.23-mm1.
It should work fine with net-2.6 too.
Benjamin
--
B e n j a m i n T h e r y - BULL/DT/Open Software R&D
http://www.bull.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NETNS-REVERT-Move-some-code-into-__init-section-when-CONFIG_NET_NS-is-not-set.patch
Type: text/x-patch
Size: 8595 bytes
Desc: not available
URL: <http://lists.openvz.org/pipermail/devel/attachments/20071026/83d79b1e/attachment-0001.bin>
-------------- next part --------------
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
More information about the Devel
mailing list