[Devel] Re: [PATCH 2/3] [NETNS49] Add struct net to all calls for rt_cache_flush

[Denis V. Lunev]

Daniel Lezcano wrote:
> Denis V. Lunev wrote:
>> commit 628d4768843fc6d572596b91e29f8ce6506c276a
>> Author: Denis V. Lunev <den at openvz.org>
>> Date:   Thu Oct 18 12:48:38 2007 +0400
>>
>>     Add struct net to all calls for rt_cache_flush. Additionally, the 
>> function
>>     manipulating with timer should not actually call the garbage 
>> collector as
>>     the namespace is not known in the global rt_secret_rebuild.
>>         Signed-off-by: Denis V. Lunev <den at openvz.org>
>>
> 
> I see you are using current->nsproxy->net_ns for sysctl stuff. Normally 
> you should use ctl->extra2 where the struct net is stored. But in the 
> case of route sysctl, it is not per namespace, so ctl->extra2 is NULL.
> I will look at that and make it per namespace, so you will be able to 
> build this patch on top of it and remove current->nsproxy->net_ns.

I think that this is quite boring. It is impossible to get the namespace 
almost anywhere even when it is safe to use this :(

extra2 is a bad place, as it has a conventional meaning for other 
kernel. For example it is used for quite a lot of sysctl-s anywhere.

Regards,
	Den