[Devel] Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

David Miller davem at davemloft.net
Thu Oct 18 05:16:47 PDT 2007


From: Pavel Emelyanov <xemul at openvz.org>
Date: Thu, 18 Oct 2007 15:53:52 +0400

> This routine scans the ipv6_fl_list whose update is
> protected with the socket lock and the ip6_sk_fl_lock.
> 
> Since the socket lock is not taken in the lookup, use
> the other one.
> 
> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>

Applied.

But I notice that I was wrong in my email, we don't
hold the socket lock here.

What prevents an unlink from the socket's list
and thus a reference count of zero occurring for
a brief moment?




More information about the Devel mailing list