[Devel] Re: [PATCH] Consolidate creation of kmem caches with "calculated" names

David Miller davem at davemloft.net
Wed Oct 17 21:27:04 PDT 2007


From: Pavel Emelyanov <xemul at openvz.org>
Date: Wed, 17 Oct 2007 17:09:30 +0400

> Some places in network (like protocol registration and dccp)
> generate the kmem cache name with snprintf() to create caches
> for several protocols with similar names.
> 
> Make the routine that makes this in one place. Possibly, this
> is better to be put in mm/sl[uoa]b.c, but I haven't found
> any other places in kernel that require such functionality,
> so put this code (temporary?) in net/core/util.c
> 
> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>

I don't think we should be putting kmem_*() interfaces in
a place like net/core/utils.c, please submit that seperately
to the SLAB and/or SLUB maintainers, and once that it in
we can add the uses to the networking.

Tanks.




More information about the Devel mailing list