[Devel] Re: [PATCH][ just for review] memory controller enhancements [1/5] force empty

[KAMEZAWA Hiroyuki]

On Tue, 16 Oct 2007 09:15:49 +0900 (JST)
yamamoto at valinux.co.jp (YAMAMOTO Takashi) wrote:

> > Index: devel-2.6.23-rc8-mm2/mm/memcontrol.c
> > ===================================================================
> > --- devel-2.6.23-rc8-mm2.orig/mm/memcontrol.c
> > +++ devel-2.6.23-rc8-mm2/mm/memcontrol.c
> > @@ -469,6 +469,7 @@ void mem_cgroup_uncharge(struct page_cgr
> >  		page = pc->page;
> >  		/*
> >  		 * get page->cgroup and clear it under lock.
> > +		 * force-empty can drop page->cgroup without checking refcnt.
> 
> force_empty
> 
> > +	char buf[2] = "0";
> 
> it should be static const unless you want a runtime assignment.
> 
Sure, thank you for pointing out.

Regards,
-Kame

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers