[Devel] Re: [PATCH 0/9] Consolidate IP fragment management

[David Miller]

From: Pavel Emelyanov <xemul at openvz.org>
Date: Fri, 12 Oct 2007 16:55:10 +0400

> Patrick recently pointed out, that there are three places that 
> perform IP fragments management. In ipv4, ipv6 and in ip6 
> conntracks. Looks like these places can be a bit consolidated.
> 
> The proposal is to create a common structure inet_frag_queue to 
> put common fields like list heads, refcounts etc in, and include
> it into the specific fragment queues. Then such objects like 
> hash tables, lists, locks etc are moved to common place (struct 
> inet_frags). At the end common code is moved to the 
> net/ipv4/inet_fragment.c.
> 
> The inet_ prefix in file names, data structures and functions, and
> the code place (net/ipv4) was proposed by Alexey, but the exact
> names were selectd by me, so maybe there can be a better ones.
> 
> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>

Thank you for doing this work, I applied it all.

I had to decide whether to apply Herbert's recent patches
first or your's, because either way there would be some
conflicts to resolve.

I handled it the best I could, but it seems OK from here.