[Devel] Re: [PATCH 0/3] Consolidate cgroup files creation for resource counters

[Balbir Singh]

Pavel Emelyanov wrote:
> Right now we have only one controller in -mm tree - the memory
> one - and it initializes all its files manually. After I developed
> the kernel memory one it turned out, that the names of resource
> counter specific files has changed. In the future, if anything in
> the resource counters change, we'll have to rewrite all the
> controllers we will have by that time.
> 
> To make all the containers working with the resource counters
> look similar I propose to create the resource counters specific
> files in one place.
> 
> Any comments/wishes before I send it to Andrew are welcome.
> 
> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>

For memory your changes make sense, but the file names cannot
be limit_in_bytes and usage_in_bytes for other controllers
(if and when they use res_counters)

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers