[Devel] Re: [PATCH 3/5] Switch caches notification dynamically

Balbir Singh balbir at linux.vnet.ibm.com
Mon Oct 1 06:38:35 PDT 2007


>>> +	if ((buf[0] == '1') && !(s->flags & SLAB_NOTIFY)) {
>> Won't this code break if I pass 10 as input in buf?
> 
> I don't care about this :) And no /sys/slab/<xxx>/ file does.
> It's the problem of a user if he pass some shit and doesn't 
> see the notifications turned on/off ;)
> 

Well, we don't want confused users? How does a user know what
is a valid value to pass? Are you saying that we don't need
to care about user interface, if so I don't agree.

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL




More information about the Devel mailing list