[Devel] Re: [PATCH] Fix memory leak in inet_hashtables.h when NUMA is on
Herbert Xu
herbert at gondor.apana.org.au
Mon Nov 26 04:36:09 PST 2007
On Fri, Nov 23, 2007 at 07:13:11PM +0300, Pavel Emelyanov wrote:
> The inet_ehash_locks_alloc() looks like this:
>
> #ifdef CONFIG_NUMA
> if (size > PAGE_SIZE)
> x = vmalloc(...);
> else
> #endif
> x = kmalloc(...);
>
> Unlike it, the inet_ehash_locks_alloc() looks like this:
>
> #ifdef CONFIG_NUMA
> if (size > PAGE_SIZE)
> vfree(x);
> else
> #else
> kfree(x);
> #endif
>
> The error is obvious - if the NUMA is on and the size
> is less than the PAGE_SIZE we leak the pointer (kfree is
> inside the #else branch).
>
> Compiler doesn't warn us because after the kfree(x) there's
> a "x = NULL" assignment, so here's another (minor?) bug: we
> don't set x to NULL under certain circumstances.
>
> Boring explanation, I know... Patch explains it better.
>
> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>
Good catch! Applied to net-2.6. Thanks.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
More information about the Devel
mailing list