[Devel] Re: [PATCH net-2.6.25] Name magic constants in sock_wake_async()

[Herbert Xu]

On Fri, Nov 23, 2007 at 04:43:11PM +0300, Pavel Emelyanov wrote:
> The sock_wake_async() performs a bit different actions 
> depending on "how" argument. Unfortunately this argument 
> ony has numerical magic values.
> 
> I propose to give names to their constants to help people 
> reading this function callers understand what's going on 
> without looking into this function all the time.
> 
> I suppose this is 2.6.25 material, but if it's not (or the
> naming seems poor/bad/awful), I can rework it against the 
> current net-2.6 tree.
> 
> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>

I like this but I admit I'm no good with names either :)

Patch applied to net-2.6.25.  Thanks Pavel!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt