[Devel] Re: [PATCH][IPVS] Fix compiler warning about unused register_ip_vs_protocol

[David Miller]

From: Pavel Emelyanov <xemul at openvz.org>
Date: Tue, 20 Nov 2007 15:08:42 +0300

> This is silly, but I have turned the CONFIG_IP_VS to m,
> to check the compilation of one (recently sent) fix
> and set all the CONFIG_IP_VS_PROTO_XXX options to n to
> speed up the compilation.
> 
> In this configuration the compiler warns me about
> 
>   CC [M]  net/ipv4/ipvs/ip_vs_proto.o
> net/ipv4/ipvs/ip_vs_proto.c:49: warning: ‘register_ip_vs_protocol’ defined but not used
> 
> Indeed. With no protocols selected there are no
> calls to this function - all are compiled out with
> ifdefs.
> 
> Maybe the best fix would be to surround this call with
> ifdef-s or tune the Kconfig dependences, but I think that
> marking this register function as __used is enough. No?
> 
> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>

No nice solutions indeed.

Simon, how should do you think we should handle this?

> diff --git a/net/ipv4/ipvs/ip_vs_proto.c b/net/ipv4/ipvs/ip_vs_proto.c
> index e844ddb..c0e11ec 100644
> --- a/net/ipv4/ipvs/ip_vs_proto.c
> +++ b/net/ipv4/ipvs/ip_vs_proto.c
> @@ -45,7 +45,7 @@ static struct ip_vs_protocol *ip_vs_proto_table[IP_VS_PROTO_TAB_SIZE];
>  /*
>   *	register an ipvs protocol
>   */
> -static int register_ip_vs_protocol(struct ip_vs_protocol *pp)
> +static int __used register_ip_vs_protocol(struct ip_vs_protocol *pp)
>  {
>  	unsigned hash = IP_VS_PROTO_HASH(pp->protocol);
>  
> -- 
> 1.5.3.4
>