[Devel] Re: [PATCH 4/4] proc: fix PDE refcounting

[Andrew Morton]

On Fri, 16 Nov 2007 18:12:41 +0300 Alexey Dobriyan <adobriyan at sw.ru> wrote:

> Creating PDEs with refcount 0 and ->deleted flag has problems (see below).
> Switch to usual scheme:
> * PDE is created with refcount 1
> * every de_get does +1
> * every de_put() and remove_proc_entry() do -1
> * once refcnt reaches 0, PDE is freed.
> 
> This elegantly fixes at least two followint races (both observed) without new
> locks, without abusing old locks, without spreading lock_kernel():

fs/reiserfs/procfs.c: In function 'r_start':
fs/reiserfs/procfs.c:424: error: 'struct proc_dir_entry' has no member named 'deleted'