[Devel] Re: [PATCH][PKTGEN] Fix double unlock of xfrm_state->lock

David Miller davem at davemloft.net
Mon Nov 19 22:51:53 PST 2007


From: Pavel Emelyanov <xemul at openvz.org>
Date: Mon, 19 Nov 2007 12:47:00 +0300

> The pktgen_output_ipsec() function can unlock this lock twice
> due to merged error and plain paths. Remove one of the calls
> to spin_unlock.
> 
> Other possible solution would be to place "return 0" right 
> after the first unlock, but at this place the err is known 
> to be 0, so these solutions are the same except for this one
> makes the code shorter.
> 
> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>

Applied, thanks Pavel.




More information about the Devel mailing list