[Devel] Re: [PATCH 6/6 net-2.6.25][RAW] Consolidate proc interface

[YOSHIFUJI Hideaki / 吉藤英明]

NAK.

In article <473DA6EF.5090004 at openvz.org> (at Fri, 16 Nov 2007 17:19:27 +0300), Pavel Emelyanov <xemul at openvz.org> says:

> @@ -858,7 +852,7 @@ static struct sock *raw_get_first(struct seq_file *seq)
>  			++state->bucket) {
>  		struct hlist_node *node;
>  
> -		sk_for_each(sk, node, &raw_v4_hashinfo.ht[state->bucket])
> +		sk_for_each(sk, node, &state->h->ht[state->bucket])
>  			if (sk->sk_family == PF_INET)
>  				goto found;
>  	}

This and

> -static struct sock *raw6_get_first(struct seq_file *seq)
> -{
> -	struct sock *sk;
> -	struct hlist_node *node;
> -	struct raw6_iter_state* state = raw6_seq_private(seq);
> -
> -	for (state->bucket = 0; state->bucket < RAW_HTABLE_SIZE;
> -			++state->bucket)
> -		sk_for_each(sk, node, &raw_v6_hashinfo.ht[state->bucket])
> -			if (sk->sk_family == PF_INET6)
> -				goto out;
> -	sk = NULL;
> -out:
> -	return sk;
> -}
> -

this are different.

--yoshfuji