[Devel] [PATCH] proc: remove useless check on symlink removal

Alexey Dobriyan adobriyan at sw.ru
Thu Nov 15 08:14:22 PST 2007


proc symlinks always have valid ->data containing destination of symlink.
No need to check it on removal -- proc_symlink() already done it.

Signed-off-by: Alexey Dobriyan <adobriyan at sw.ru>
---

 fs/proc/generic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -704,7 +704,7 @@ void free_proc_entry(struct proc_dir_entry *de)
 
 	release_inode_number(ino);
 
-	if (S_ISLNK(de->mode) && de->data)
+	if (S_ISLNK(de->mode))
 		kfree(de->data);
 	kfree(de);
 }




More information about the Devel mailing list