[Devel] Re: [PATCH][NET] Convert init_timer into setup_timer

David Miller davem at davemloft.net
Tue Nov 13 21:14:28 PST 2007


From: "Arnaldo Carvalho de Melo" <acme at redhat.com>
Date: Tue, 13 Nov 2007 11:43:40 -0200

> Em Tue, Nov 13, 2007 at 05:34:21AM -0800, David Miller escreveu:
> > From: Pavel Emelyanov <xemul at openvz.org>
> > Date: Tue, 13 Nov 2007 16:10:03 +0300
> > 
> > > Many-many code in the kernel initialized the timer->function 
> > > and  timer->data together with calling init_timer(timer). There 
> > > is already a helper for this. Use it for networking code.
> > > 
> > > The patch is HUGE, but makes the code 130 lines shorter 
> > > (98 insertions(+), 228 deletions(-)).
> > > 
> > > Signed-off-by: Pavel Emelyanov <xemul at openvz.org>
> > 
> > I have no objection to this patch, but it is 2.6.25
> > material for sure.
> 
> Agreed, Pavel, if you want please stick:
> 
> Acked-by: Arnaldo Carvalho de Melo <acme at redhat.com>

No need, I've applied it to net-2.6.25 :-)




More information about the Devel mailing list