[Devel] Re: [PATCH 2/4] Add missed tunnel64_err handler

[David Miller]

From: Pavel Emelyanov <xemul at openvz.org>
Date: Fri, 09 Nov 2007 16:14:12 +0300

> The tunnel64_protocol uses the tunnel4_protocol's err_handler and
> thus calls the tunnel4_protocol's handlers.
> 
> This is not very good, as in case of (icmp) error the wrong error
> handlers will be called (e.g. ipip ones instead of sit) and this
> won't be noticed at all, because the error is not reported.
> 
> Was that made deliberately and I miss something?
> 
> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>

This definitely was doing the wrong thing for the SIT
case, for example.  So this looks legitimate to me.

Patch applied, thanks!