[Devel] [RFC][PATCH 04/16] Use pid_to_nr() in process info functions

sukadev at us.ibm.com sukadev at us.ibm.com
Fri May 25 15:53:18 PDT 2007


Pavel Emelianov [xemul at sw.ru] wrote:
| > ===================================================================
| > --- lx26-21-mm2.orig/kernel/timer.c	2007-05-22 16:58:38.000000000 -0700
| > +++ lx26-21-mm2/kernel/timer.c	2007-05-22 16:59:44.000000000 -0700
| > @@ -945,7 +945,7 @@ asmlinkage long sys_getppid(void)
| >  	int pid;
| >  
| >  	rcu_read_lock();
| > -	pid = rcu_dereference(current->real_parent)->tgid;
| > +	pid = pid_to_nr(task_parent_tgid(current));
| 
| This breaks fsys_getppid() call in ia64...

Good catch. I need to figure out how to make the pid_to_nr()
call in IA64 assembly and if there are other architectures
that implement in assembly.

But in general, do you see any problems with the interfaces
like task_parent_tgid() ?

| 
| >  	rcu_read_unlock();
| >  
| >  	return pid;
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list