[Devel] Re: [PATCH 5/13] Expand the pid/task seeking functions set

[Dave Hansen]

On Thu, 2007-05-24 at 16:50 +0400, Pavel Emelianov wrote:
> 
> +struct pid * fastcall __find_vpid(int nr, struct pid_namespace *ns)
> +{
> +#ifdef CONFIG_PID_NS
> +       struct hlist_node *elem;
> +       struct pid *pid;
> +#endif
> +
> +       if (ns == &init_pid_ns)
> +               return find_pid(nr);
> +
> +#ifdef CONFIG_PID_NS
> +       hlist_for_each_entry_rcu(pid, elem,
> +                       &vpid_hash[vpid_hashfn(nr, ns)], vpid_chain) {
> +               if (pid->vnr == nr && pid->ns == ns)
> +                       return pid;
> +       }
> +#endif
> +       return NULL;
> +} 

I am a bit worried that there are too many #ifdefs here.  Your patch
series adds ~20 of them, and they look to me to be mostly in .c files.
Section 2 in SubmittingPatches somewhat discourages this.

Do you have any plans for cleaning these up?

-- Dave

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers