[Devel] Re: LTP: serge2 hostname

Serge E. Hallyn serue at us.ibm.com
Wed May 23 07:49:44 PDT 2007


Quoting Alexey Dobriyan (adobriyan at sw.ru):
> I ran ltp-full-20070430 and utstest.c forgot to restore original
> hostname from serge2. ;-)

Oh that's just me taking over the world, one workstation at a time.

Hopefully this simple obvious silly workaround fixes it?

It should also fix 'make no_ltp' which I hadn't realized was broken
until I just tried to test the hostname fix...

thanks for spotting that.

-serge

Only in ltp-full-20070430-fixserge2/testcases/kernel/containers/libclone: libclone.a
Only in ltp-full-20070430-fixserge2/testcases/kernel/containers/libclone: libclone.o
diff -ur ltp-full-20070430/testcases/kernel/containers/utsname/Makefile ltp-full-20070430-fixserge2/testcases/kernel/containers/utsname/Makefile
--- ltp-full-20070430/testcases/kernel/containers/utsname/Makefile	2007-04-26 13:02:51.000000000 +0200
+++ ltp-full-20070430-fixserge2/testcases/kernel/containers/utsname/Makefile	2007-05-23 16:48:26.000000000 +0200
@@ -4,8 +4,9 @@
 LDLIBS += -L../../../../lib -L../libclone ../libclone/libclone.a -lltp
 
 SRCS    = $(wildcard *.c)
+NOLTPSRCS = utstest.c
 TARGETS = $(patsubst %.c,%,$(SRCS))
-NOLTP_TARGETS = $(patsubst %.c,%_noltp,$(SRCS))
+NOLTP_TARGETS = $(patsubst %.c,%_noltp,$(NOLTPSRCS))
 
 %_noltp : %.c
 	$(CC) -g -DNO_LTP -o $@ $< ../libclone/libclone.a
diff -ur ltp-full-20070430/testcases/kernel/containers/utsname/runtests_noltp.sh ltp-full-20070430-fixserge2/testcases/kernel/containers/utsname/runtests_noltp.sh
--- ltp-full-20070430/testcases/kernel/containers/utsname/runtests_noltp.sh	2007-04-26 13:02:51.000000000 +0200
+++ ltp-full-20070430-fixserge2/testcases/kernel/containers/utsname/runtests_noltp.sh	2007-05-23 16:44:32.000000000 +0200
@@ -1,5 +1,6 @@
 #!/bin/sh
 
+oldhostname=`hostname`
 exit_code=0
 echo "unshare tests"
 for i in `seq 1 5`; do
@@ -17,4 +18,5 @@
 		exit_code=$?
 	fi
 done
+hostname "$oldhostname"
 exit $exit_code
diff -ur ltp-full-20070430/testcases/kernel/containers/utsname/runutstest.sh ltp-full-20070430-fixserge2/testcases/kernel/containers/utsname/runutstest.sh
--- ltp-full-20070430/testcases/kernel/containers/utsname/runutstest.sh	2007-04-26 13:02:51.000000000 +0200
+++ ltp-full-20070430-fixserge2/testcases/kernel/containers/utsname/runutstest.sh	2007-05-23 16:44:37.000000000 +0200
@@ -1,5 +1,6 @@
 #!/bin/sh
 
+oldhostname=`hostname`
 echo "unshare tests"
 for i in `seq 1 5`; do
 	echo "test $i (unshare)"
@@ -10,3 +11,4 @@
 	echo "test $i (clone)"
 	utstest clone $i
 done
+hostname "$oldhostname"
Only in ltp-full-20070430-fixserge2/testcases/kernel/containers/utsname: utstest_noltp




More information about the Devel mailing list