[Devel] Re: [ckrm-tech] [PATCH 1/7] containers (V7): Generic container system abstracted from cpusets code

Paul Jackson pj at sgi.com
Sat Mar 24 18:41:28 PDT 2007


vatsa wrote:
> >         if (tsk->flags & PF_EXITING) {
> 
> What if PF_EXITING is set after this check? If that happens then,
> 
> >                 task_unlock(tsk);
> >                 mutex_unlock(&callback_mutex);
> >                 put_task_struct(tsk);
> >                 return -ESRCH;
> >         }
> 
> the following code becomes racy with cpuset_exit() ...
> 
>         atomic_inc(&cs->count);
>         rcu_assign_pointer(tsk->cpuset, cs);
>         task_unlock(tsk);

eh ... so ... ?

I don't know of any sequence where that causes any problem.

Do you see one?

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj at sgi.com> 1.925.600.0401




More information about the Devel mailing list