[Devel] Re: [RFC][PATCH 04/14] Add struct pid_nr and pid_nrs list

[Eric W. Biederman]

sukadev at us.ibm.com writes:

> From: Sukadev Bhattiprolu <sukadev at us.ibm.com>
> Subject: [RFC][PATCH 04/14] Add struct pid_nr and pid_nrs list
>
> A struct pid_nr associates a pid_t value with a pid namespace. We attach
> a list of struct pid_nr entries to a struct pid (pid->pid_nrs), allowing
> the struct pid to take different pid_t values in different namespaces.
>
> The pid->pid_nrs list and the helper functions will be used in subsequent
> functions.

Ok.  Things are getting there.  However in a practical sense you
have spread one logical change over several patches and the review
is a pain because things are to fine, an cases of code movement don't
look it because they are split over multiple patches.

I think patches 4,5?,6,7,8 all should be a single patch
that just splits struct pid_nr from struct pid.

Eric
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers