[Devel] Re: [RFC][PATCH 02/14] Move alloc_pid call to copy_process

Eric W. Biederman ebiederm at xmission.com
Wed Mar 21 00:08:56 PDT 2007


sukadev at us.ibm.com writes:

> From: Sukadev Bhattiprolu <sukadev at us.ibm.com>
> Subject: [RFC][PATCH 02/14] Move alloc_pid call to copy_process
>
> Move alloc_pid() into copy_process(). This will help in
> code to support cloning of pid namespace.

I think this makes sense.  However if we are doing it let's
put the special case code for the init_pid in free_pid and
pass the type to alloc_pid. 

Otherwise all of the extra if look ugly in copy_process.
Putting them in alloc_pid and free_pid doesn't really get rid
of them but at least it keeps them in a very pid context.

Eric
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list