[Devel] Re: + remove-the-likelypid-check-in-copy_process.patch added to -mm tree

[Eric W. Biederman]

Oleg Nesterov <oleg at tv-sign.ru> writes:

> Yes! I meant we should change INIT_SIGNALS(), currently it does
>
> 	#define INIT_SIGNALS(sig) {
> 		...
> 		.pgrp           = 1,
> 		{ .__session      = 1},
>
> and this confuses (I think) set_special_pids(1,1) above. Because
> __set_special_pids() still deals with pid_t, not "struct pid".
>
> Unless I missed something, we should kill these 2 initializations
> above.

Got it.  I agree we should initialize those fields to 0.

Sukadev you want to get that?

Eric
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers