[Devel] Re: [RFC][PATCH 3/6] pid namespace : use struct pid_nr

[Cedric Le Goater]

>> Index: lx26-20-mm2b/kernel/pid.c
>> ===================================================================
>> --- lx26-20-mm2b.orig/kernel/pid.c	2007-03-09 15:29:21.000000000 -0800
>> +++ lx26-20-mm2b/kernel/pid.c	2007-03-09 15:29:23.000000000 -0800
>> @@ -180,8 +180,19 @@ fastcall void put_pid(struct pid *pid)
>>  	if (!pid)
>>  		return;
>>  	if ((atomic_read(&pid->count) == 1) ||
>> -	     atomic_dec_and_test(&pid->count))
>> +	     atomic_dec_and_test(&pid->count)) {
>> +		struct pid_nr* pid_nr;
>> +		struct hlist_node *pos, *next;
>> +
>> +		/*
>> +		 * rcu is not needed anymore
>> +		 */
> 
> rcu should never be needed...
> We should be able to get away with a definition that is immutable for the
> lifetime of a struct pid.

but struct pid requires to be rcu safe and as the new struct pid_nr is a
member of struct pid, it seems that the same rule should apply. nop ? 

Cheers,

C. 
_______________________________________________
Containers mailing list
Containers at lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers