[Devel] Re: [PATCH 1/2] Fix some coding-style errors in autofs

Randy.Dunlap rdunlap at xenotime.net
Mon Mar 12 22:02:18 PDT 2007


On Mon, 12 Mar 2007 sukadev at us.ibm.com wrote:

> From: Sukadev Bhattiprolu <sukadev at us.ibm.com>
> Subject: [PATCH 1/2] Fix some coding-style errors in autofs
>
> Fix coding style errors (extra spaces, long lines) in autofs
> and autofs4 files being modified for container/pidspace issues.
>
> ---
>  fs/autofs/inode.c  |   29 +++++++++++--------
>  fs/autofs/root.c   |   77 ++++++++++++++++++++++++++---------------------------
>  fs/autofs4/inode.c |   16 ++++-------
>  fs/autofs4/root.c  |   18 ++++++------
>  4 files changed, 70 insertions(+), 70 deletions(-)
>
> Index: lx26-20-mm2c/fs/autofs/inode.c
> ===================================================================
> --- lx26-20-mm2c.orig/fs/autofs/inode.c	2007-02-28 14:48:35.000000000 -0800
> +++ lx26-20-mm2c/fs/autofs/inode.c	2007-02-28 15:47:09.000000000 -0800
> @@ -34,12 +34,12 @@ void autofs_kill_sb(struct super_block *
>
>  	autofs_hash_nuke(sbi);
> -	for ( n = 0 ; n < AUTOFS_MAX_SYMLINKS ; n++ ) {
> -		if ( test_bit(n, sbi->symlink_bitmap) )
> +	for (n = 0 ; n < AUTOFS_MAX_SYMLINKS ; n++) {
> +		if (test_bit(n, sbi->symlink_bitmap))
>  			kfree(sbi->symlink[n].data);
>  	}

Please do a complete job on the 'for' line by eliminating the
space before each semi-colon.

-- 
~Randy
_______________________________________________
Containers mailing list
Containers at lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers




More information about the Devel mailing list