[Devel] Re: [PATCH 1/28] [PREP 1/14] Round up the API

Pavel Emelianov xemul at openvz.org
Tue Jun 19 04:01:02 PDT 2007


Cedric Le Goater wrote:
> Pavel Emelianov wrote:
>> The set of functions process_session, task_session, process_group
>> and task_pgrp is confusing, as the names can be mixed with each other
>> when looking at the code for a long time.
>>
>> The proposals are to
>> * equip the functions that return the integer with _nr suffix to
>>   represent that fact,
>> * and to make all functions work with task (not process) by making
>>   the common prefix of the same name.
>>
>> For monotony the routines signal_session() and set_signal_session()
>> are replaced with task_session_nr() and set_task_session(), especially
>> since they are only used with the explicit task->signal dereference.
>>
>> Signed-off-by: Pavel Emelianov <xemul at openvz.org>
>> Acked-by: Serge E. Hallyn <serue at us.ibm.com>
> 
> I think we all agreed on this one. Can you send it to lkml@ as a 
> candidate for -mm ?

I already did that actually. But Andrew didn't answer so I 
decided that he considers this patch to be the part of the
pid namespaces.

I will resend it this week separately if get no other 
response from him.

> Thanks,
> 
> C. 
> 

Thanks,
Pavel
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list