[Devel] Re: [PATCH 10/15] Make each namespace has its own proc tree

Pavel Emelyanov xemul at openvz.org
Sun Jul 29 23:45:46 PDT 2007


Oleg Nesterov wrote:
> On 07/29, Oleg Nesterov wrote:
>> Look, proc_flush_task() doesn't need pid, it can use active pid_ns
> 
> Oops. Yes, proc_flush_task() doesn't use ->numbers[].nr, but it should?
> 
> proc_flush_task_mnt() uses task->pid to flush /proc/$pid, this looks wrong,
> we should use ->number[ns->level].nr, no?

Indeed. Hmm, why then pids were released during my tests...
Looks like we do still need struct pid for proc_flush_task().

> Oleg.

Thanks,
Pavel




More information about the Devel mailing list