[Devel] Re: [PATCH 3/15] kern_siginfo helper

[Oleg Nesterov]

On 07/26, Pavel Emelyanov wrote:
>
> TODO: 	This is more an exploratory patch and modifies only interfaces
> 	necessary to implement correct signal semantics in pid namespaces.
> 	
> 	If the approach is feasible, we could consistently use 'kern_siginfo'
> 	in other signal interfaces and possibly in 'struct sigqueue'.
> 
> 	We could modify dequeue_signal() to directly work with 'kern_siginfo'
> 	and remove dequeue_signal_kern_info().

Well... I know, it is very easy to blame somebody else's patch, and probably
my taste is not good...

But honestly, I personally think this approach is a horror, and any alternative
is better :)

I'd rather change dequeue_signal() so that it takes "struct sigqueue *"
parameter instead of "siginfo_t *", or add a new "int *flags".

OK, this doesn't work anyway, we should do something different. Perhaps
just do all checks on sender's side.

It is a bit strange that this patch is 3/15, and the rest bits in 11/15,
not very convenient for the review.

Oleg.