[Devel] Re: [PATCH] Remove CTL_UNNUMBERED

Eric W. Biederman ebiederm at xmission.com
Thu Jul 26 10:24:12 PDT 2007


Alexey Dobriyan <adobriyan at sw.ru> writes:

> CTL_UNNUMBERED is unneeded, because it expands to
>
> 	.ctl_name = 0
>
> The same effect can be achieved by skipping .ctl_name initialization,
> saving one line per sysctl.
>
> Update docs and headers telling people to not add CTL_ numbers and
> giving example.
>
> This is probably all we can do to stop the flow of new CTL_ numbers,
> because most of sysctls are copy-pasted. CTL_UNNUMBERED doesn't solve
> this problem at all.
>
> Signed-off-by: Alexey Dobriyan <adobriyan at sw.ru>

Nack.  Not unless you update the documentation and explanations
properly.

The important part is that we stop assigning binary numbers.  You
are removing part of the description of why we can not assign bianry
numbers and how that is important.

CTL_UNNUMBERED may be an irritant to you but as for actually using the
code I have look and it is about 6 of 1 half dozen of the other.

Eric




More information about the Devel mailing list