[Devel] Re: [PATCH 02/10] Task Containers(V11): Add tasks file interface

Paul Menage menage at google.com
Fri Jul 20 14:25:41 PDT 2007


On 7/20/07, James Morris <jmorris at namei.org> wrote:
> > +             if ((current->euid) && (current->euid != tsk->uid)
> > +                 && (current->euid != tsk->suid)) {
> > +                     put_task_struct(tsk);
> > +                     return -EACCES;
>
> I wonder if we should allow CAP_SYS_ADMIN to do this, too.
>

Yes, I ought to replace "current->euid" with "capable(CAP_SYS_ADMIN)".

Thanks,

Paul




More information about the Devel mailing list