[Devel] Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}

[Ingo Molnar]

* Alexey Dobriyan <adobriyan at sw.ru> wrote:

> On every open/close one struct seq_operations leaks.
> Kudos to /proc/slab_allocators.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan at sw.ru>

ouch ...

Acked-by: Ingo Molnar <mingo at elte.hu>

-stable material too, as far as timer_info/stats goes.

> -       .release        = seq_release,
> +       .release        = single_release,

i think seq_release() definitely needs to grow a WARN_ON() if it's being 
used on an inode that was opened via single_open(). This bug is so 
easily committed, and nothing but a small leak reminds us on it.

	Ingo