[Devel] [PATCH] se401: fix "&& 0x" typo

Alexey Dobriyan adobriyan at sw.ru
Mon Jul 2 04:04:53 PDT 2007


Code there survived trivial regexp made earlier, but after bulk preprocessing
was done...

===>	if (!cp[2] && 0x40) {	<===
		printk("<3>" "%s: " "Bayer format not supported!" ...
		return 1;
	}


NOTE: to me, check or error message should be reverted, but I know nothing
about this driver.

Signed-off-by: Alexey Dobriyan <adobriyan at sw.ru>
---

 drivers/media/video/se401.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/media/video/se401.c
+++ b/drivers/media/video/se401.c
@@ -1280,7 +1280,7 @@ static int se401_init(struct usb_se401 *se401, int button)
 	rc=se401_sndctrl(0, se401, SE401_REQ_GET_HEIGHT, 0, cp, sizeof(cp));
 	se401->cheight=cp[0]+cp[1]*256;
 
-	if (!cp[2] && SE401_FORMAT_BAYER) {
+	if (!(cp[2] & SE401_FORMAT_BAYER)) {
 		err("Bayer format not supported!");
 		return 1;
 	}




More information about the Devel mailing list