[Devel] gentoo baselayout 1.13 openvz modifications
Kir Kolyshkin
kir at openvz.org
Mon Jan 22 06:58:05 PST 2007
Hello,
I was checking the stuff added to Gentoo's baselayout 1.13 to make it
compatible with VPS systems like Linux-VServer or OpenVZ.
Everything looks great, the only minor problem I found is this code in
bootmisc:
if [[ $(uname) == "Linux" ]] && ! is_vps_sys ; then
# BSD has it's own sysctl init script
if [[ -e /etc/sysctl.conf ]] ; then
ebegin $"Configuring kernel parameters"
sysctl -q -p /etc/sysctl.conf
eend $?
fi
fi
The problem here is in OpenVZ some of sysctl variables are virtualized,
i.e. you can set it from inside your VE. Usually this is not needed, and
not too many people do that, but still if there is /etc/sysctl.conf
people expect that it will be applied during VE start.
Surely this is minor problem and it does not cry for fixing it now.
Still, at the very least it would be helpful to add FIXME or TODO-like
comment in the code.
Regards,
Kir.
PS version checked is baselayout-1.13.0_alpha12
More information about the Devel
mailing list