[Devel] Re: [PATCH 1/2] Consolidate bust_spinlocks()

[Martin Schwidefsky]

On Thu, 2007-01-18 at 14:16 +0300, Alexey Dobriyan wrote:
> From: Kirill Korotaev <dev at sw.ru>
> 
> Part of long forgotten patch
> http://groups.google.com/group/fa.linux.kernel/msg/e98e941ce1cf29f6?dmode=source
> Since then, m32r grabbed two copies.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan at openvz.org>
> ---
> 
>  arch/i386/mm/fault.c       |   26 --------------------------
>  arch/ia64/kernel/traps.c   |   30 ------------------------------
>  arch/m32r/mm/fault-nommu.c |   26 --------------------------
>  arch/m32r/mm/fault.c       |   26 --------------------------
>  arch/s390/mm/fault.c       |   26 --------------------------
>  arch/x86_64/mm/fault.c     |   21 ---------------------
>  lib/Makefile               |    4 ++--
>  lib/bust_spinlocks.c       |    2 +-
>  8 files changed, 3 insertions(+), 158 deletions(-)

NACK for the s390 part. lib/bust_spinlocks.c does an unblank_screen if
CONFIG_VT is defined. That is not good enough for s390 because we do not
have CONFIG_VT nor unblank_screen but still require that console_unblank
is called.

-- 
blue skies,
  Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.