[Devel] Re: [PATCH] Use struct pid parameter in copy_process()

[Eric W. Biederman]

sukadev at us.ibm.com writes:

> From: Sukadev Bhattiprolu <sukadev at us.ibm.com>
> Subject: [PATCH] Use struct pid parameter in copy_process()
>
> Modify copy_process() to take a struct pid * parameter instead of a pid_t.
> This simplifies the code a bit and also avoids having to call find_pid()
> to convert the pid_t to a struct pid.

I would recommend doing this in 2 steps:
- One patch to kill the likely(p->pid).
- And another to kill change the pid argument.

The indentation change makes it really hard to see what
the change in pid argument buys.

This also needs to be part of the patchset that adds a dummy
struct pid to init, to make the dependency clear.

Also given that you change the type there is no need to change
the name of the pid parameter to copy process, and the spid
name just looks strange.

Eric
_______________________________________________
Containers mailing list
Containers at lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers