[Devel] [PATCH] ecryptfs remove unnecessary flush_dcache_page
Dmitriy Monakhov
dmonakhov at sw.ru
Wed Feb 21 23:34:00 PST 2007
Dmitriy Monakhov <dmonakhov at openvz.org> writes:
> 1)Function ecryptfs_do_readpage() calls flush_dcache_page(lower_page),
> but lower_page was't changed here. So remove this line.
>
> 2)prepare_write ret val was ignored in ecryptfs_write_inode_size_to_header().
> If error happends we can't call commit_write, just do cleanup and fial.
> It is issue easy to reproduce with full lower_fs, in this case prepare_write()
Second issue was fixed by "ecryptfs-resolve-lower-page-unlocking-problem.patch",
but first issue was't.
[LOG]
Function ecryptfs_do_readpage() calls flush_dcache_page(lower_page),
but lower_page was't changed here. Even if it was changed by
lower_a_ops->readpage() dcache was flushed by readpage() itself.
So remove this unnecessary line.
Signed-off-by: Dmitriy Monakhov <dmonakhov at openvz.org>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff-mm-ecryptfs-false-flush_dcache
URL: <http://lists.openvz.org/pipermail/devel/attachments/20070222/a4ad42e1/attachment-0001.ksh>
More information about the Devel
mailing list