[Devel] Re: [RFC PATCH 2/4] namespace containers: move nsproxy setting code

[Serge E. Hallyn]

Quoting Paul Menage (menage at google.com):
> On 2/12/07, Serge E. Hallyn <serue at us.ibm.com> wrote:
> >From: "Serge E. Hallyn" <serue at us.ibm.com>
> >Subject: [RFC PATCH 2/4] namespace containers: move nsproxy setting code
> >
> >Move nsproxy setting code from clone and unshare into container_clone.
> 
> Please can you keep the knowledge of nsproxy outside of the generic
> container code? If there's some additional work required by a
> subsystem when a container is cloned, we should have additional
> callbacks.
> 
> But in this case, can't you just do the swap_nsproxies() in
> ns_container_clone(), either before or after calling
> container_clone()?

I guess that's fine.  I was doing it as late as possible because I
was worried about failure later on, but the callers handle failure
appropriately so it should be fine.

thanks,
-serge