[Devel] [RFC][PATCH] pidspace in coda fs

sukadev at us.ibm.com sukadev at us.ibm.com
Fri Feb 2 11:18:30 PST 2007


Hi

I am trying to understand how the pid, pgid, and sid fields coda_in_hdr
are used. Are they really required ? If so, can you please review/comment
on the following patch. If they are not required, can I submit a patch
to remove the three fields ?

Appreciate your input.

Suka

---


Use container-safe interfaces for pid and pgid.

---
 fs/coda/upcall.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: lx26-20-rc6-mm3/fs/coda/upcall.c
===================================================================
--- lx26-20-rc6-mm3.orig/fs/coda/upcall.c	2006-11-29 13:57:37.000000000 -0800
+++ lx26-20-rc6-mm3/fs/coda/upcall.c	2007-02-02 11:05:56.000000000 -0800
@@ -52,8 +52,8 @@ static void *alloc_upcall(int opcode, in
 		return ERR_PTR(-ENOMEM);
 
         inp->ih.opcode = opcode;
-	inp->ih.pid = current->pid;
-	inp->ih.pgid = process_group(current);
+	inp->ih.pid = pid_nr(task_pid(current));
+	inp->ih.pgid = pid_nr(task_pgrp(current));
 #ifdef CONFIG_CODA_FS_OLD_API
 	memset(&inp->ih.cred, 0, sizeof(struct coda_cred));
 	inp->ih.cred.cr_fsuid = current->fsuid;
_______________________________________________
Containers mailing list
Containers at lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers




More information about the Devel mailing list