[Devel] [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.

David Miller davem at davemloft.net
Thu Dec 13 06:49:55 PST 2007


From: Alexey Dobriyan <adobriyan at sw.ru>
Date: Thu, 13 Dec 2007 17:47:07 +0300

> On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote:
> > There are to many spaces between type and function name in the declaration
> > of fib rules manipulation routines. Eat them and save a couple of lines.
> 
> If this patch is going in, it would be nice to get rid of "extern" as
> well.

The convention in the networking headers is to use extern, and
this is pretty consistently done across the board.

If we are going to do this, which I personally see no reason
for, we should do it across the whole networking.

Consistency is much more important than whatever reason you
could come up with to get rid of the 'extern'.




More information about the Devel mailing list