[Devel] Re: [PATCH][IPVS] Fix sched registration race when checking for name collision

David Miller davem at davemloft.net
Tue Dec 4 00:45:25 PST 2007


From: Simon Horman <horms at verge.net.au>
Date: Tue, 4 Dec 2007 10:41:43 +0900

> On Mon, Dec 03, 2007 at 01:10:57PM +0300, Pavel Emelyanov wrote:
> > The register_ip_vs_scheduler() checks for the scheduler with the
> > same name under the read-locked __ip_vs_sched_lock, then drops,
> > takes it for writing and puts the scheduler in list.
> > 
> > This is racy, since we can have a race window between the lock
> > being re-locked for writing.
> > 
> > The fix is to search the scheduler with the given name right under
> > the write-locked __ip_vs_sched_lock.
> 
> This looks correct to me.
> 
> > Signed-off-by: Pavel Emelyanov <xemul at openvz.org>
> 
> Acked-by: Simon Horman <horms at verge.net.au>

Also applied, thanks a lot.




More information about the Devel mailing list