[Devel] Re: [PATCH][IPVS] Don't leak sysctl tables if the scheduler registration fails

[David Miller]

From: Simon Horman <horms at verge.net.au>
Date: Tue, 4 Dec 2007 10:36:48 +0900

> On Mon, Dec 03, 2007 at 01:04:53PM +0300, Pavel Emelyanov wrote:
> > In case we load lblc or lblcr module we can leak some sysctl
> > tables if the call to register_ip_vs_scheduler() fails.
> 
> This looks correct to me.
> 
> > I've looked at the register_ip_vs_scheduler() code and saw, that
> > the only reason to fail is the name collision, so I think that
> > with some 3rd party schedulers this becomes a relevant issue. No?
> 
> I guess so. Though presumably register_ip_vs_scheduler() could
> have other modes of failure in the future.
> 
> > Signed-off-by: Pavel Emelyanov <xemul at openvz.org>
> 
> Acked-by: Simon Horman <horms at verge.net.au>

Applied, thanks.