[Devel] Re: [PATCH net-2.6.25 1/6][CORE] Remove unneeded ifdefs from sysctl_net_core.c

[Eric W. Biederman]

Pavel Emelyanov <xemul at openvz.org> writes:

> They include the whole file, but it is already compiled
> out when SYSCTL=n, since it is obj-$(CONFIG_SYSCTL) target
> in the Makefile.

Pavel thanks for sending these patches.  Might I ask
for some level of acknowledgement when you rework one of
my patches and send it off.

I suppose this could be a case of duplicate thinking but
this patch looks very familiar.

Eric


> Signed-off-by: Pavel Emelyanov <xemul at openvz.org>
>
> ---
>
> diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
> index 113cc72..277c8fa 100644
> --- a/net/core/sysctl_net_core.c
> +++ b/net/core/sysctl_net_core.c
> @@ -13,8 +13,6 @@
>  #include <net/sock.h>
>  #include <net/xfrm.h>
>  
> -#ifdef CONFIG_SYSCTL
> -
>  ctl_table core_table[] = {
>  #ifdef CONFIG_NET
>  	{
> @@ -151,5 +149,3 @@ ctl_table core_table[] = {
>  	},
>  	{ .ctl_name = 0 }
>  };
> -
> -#endif
> -- 
> 1.5.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html