[Devel] Re: [PATCH] pci_get_device call from interrupt in reboot fixups

[Greg KH]

On Fri, Aug 03, 2007 at 02:39:24PM +0400, Denis V. Lunev wrote:
> The following calltrace is possible now:
>  handle_sysrq
>    machine_emergency_restart
>      mach_reboot_fixups
>        pci_get_device
>          pci_get_subsys
> 	   down_read
> The patch obtains PCI device during initialization to avoid bothering PCI
> search engine in interrupt. Devices used in this code are not supposed to
> be pluggable, so it looks safe to keep them.

What devices are supposed to be affected here?  Are you sure that they
can't be removed later?  Grabbing references here might mess with them
in the future.

thanks,

greg k-h